.NET LINQ enumeration and EF query boundaries

A tool-agnostic recipe to avoid repeated enumeration, client evaluation, N+1 loading, and leaked query lifetimes. It supports a read-only audit and, when explicitly authorized, a narrow remediation.

When to use it

Use this recipe when the operator’s specific objective is to avoid repeated enumeration, client evaluation, N+1 loading, and leaked query lifetimes. Prefer a narrower CVE, scanner-finding, security-audit, or compliance-evidence recipe when that is the operator’s actual job.

Inputs

  • Repository root and the files, package, service, or module in scope.
  • Requested mode: audit or explicitly authorized fix.
  • Supported runtime, compiler, framework, operating-system, and deployment versions inferred from repository files.
  • Existing formatter, compiler, analyzer, test, build, and package-manager commands.
  • Public API, compatibility, performance, generated-code, vendor, and migration constraints.

The prompt

You are running the Security Recipes code-hygiene workflow `code-hygiene.dotnet.dotnet-linq-enumeration-and-ef-query-boundaries`.

Start read-only. Do not edit files until the operator explicitly authorizes a fix.
Use repository configuration and installed tool versions as authoritative; do not impose a new style or toolchain.

### Scope

Your bounded objective is to avoid repeated enumeration, client evaluation, N+1 loading, and leaked query lifetimes.
Inspect only operator-scoped, first-party source and configuration. Exclude generated, vendored, minified, fixture snapshot, lock history, and migration history unless explicitly included.

### Detection

- Trace IQueryable versus IEnumerable transitions, materialization points, repeated enumeration, includes, and per-row queries.
- Inspect DbContext lifetime and transaction boundaries.
- Record file and symbol evidence for every candidate. Mark uncertain or dynamically reachable behavior instead of guessing.

### Fix, only when authorized

- Materialize deliberately, shape server-side queries, and batch related data without hiding query costs.
- Keep the diff limited to the proven issue and its focused tests. Preserve public behavior, API compatibility, and repository conventions.
- Do not add or broaden suppressions, weaken diagnostics, mass-format unrelated files, upgrade dependencies, or mutate external state.

### Verification

- Assert query counts and generated SQL where supported plus result, cancellation, and transaction tests.
- Compare diagnostic counts and relevant behavior before and after. Report every command, result, and check that could not run.

### Stop conditions

- Stop if query changes need production data distribution or indexing decisions.
- Stop and hand off to a focused security recipe if evidence indicates a vulnerability, secret exposure, authorization failure, injection path, or named CVE.
- Stop rather than widening scope when the safe result requires architecture, product, compliance, operational, or data-owner decisions.

Output contract

  • Scope and repository evidence reviewed.
  • A candidate table with file or symbol, evidence, confidence, and disposition.
  • In audit mode: no edits, plus the smallest safe next action for each confirmed item.
  • In fix mode: one bounded patch, focused regression coverage, and no unrelated cleanup.
  • Commands run, results, remaining uncertainty, and any stop-condition handoff.

Verification

  • Assert query counts and generated SQL where supported plus result, cancellation, and transaction tests.
  • Confirm that diagnostic configuration, suppressions, public interfaces, generated files, vendored files, and dependencies did not change outside the authorized scope.
  • Review the final diff for behavior changes and run the repository’s focused checks before broader suites.

Guardrails

  • Read-only until edits are explicitly authorized.
  • Do not deploy, publish, rotate secrets, alter cloud or database state, change CI permissions, or open external tickets.
  • Do not hide debt by disabling rules, adding retries or sleeps, weakening tests, broadening ignores, or lowering warning levels.
  • Treat generated, vendored, minified, migration-history, and fixture-snapshot files as out of scope unless explicitly named.
  • Stop if query changes need production data distribution or indexing decisions.

References